Add interrupt feature #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ 95cbcc6
Click for full report table
Click for full report CSV |
per1234
previously requested changes
May 12, 2021
There was a problem hiding this comment.
You can fix the spell check failure by adding the problematic word in all lower case (als) here;
https://github.com/arduino-libraries/Arduino_APDS9960/blob/master/.codespellrc#L4
Co-authored-by: per1234 <accounts@perglass.com>
|
Memory usage change @ bb0a9b4
Click for full report table
Click for full report CSV |
Rocketct
reviewed
Jul 26, 2021
| @@ -52,7 +52,7 @@ bool APDS9960::begin() { | |||
| if (!setWTIME(0xFF)) return false; | |||
| if (!setGPULSE(0x8F)) return false; // 16us, 16 pulses // default is: 0x40 = 8us, 1 pulse | |||
| if (!setPPULSE(0x8F)) return false; // 16us, 16 pulses // default is: 0x40 = 8us, 1 pulse | |||
| if (!setGestureIntEnable(true)) return false; | |||
| //if (!setGestureIntEnable(true)) return false; | |||
There was a problem hiding this comment.
this is not fine, if useless remove the cmment otherwise add and fix incompatibility
Comment on lines
+69
to
+70
| /*clearLightInterrupt(); | ||
| clearProximityInterrupt();*/ |
| @@ -428,15 +433,99 @@ int APDS9960::readProximity() { | |||
| return -1; | |||
| } | |||
|
|
|||
| disableProximity(); | |||
| //disableProximity(); | |||
| #if defined(APDS9960_INT_PIN) | ||
| APDS9960 APDS(APDS9960_WIRE_INSTANCE, APDS9960_INT_PIN); | ||
| #elif defined(ARDUINO_ARDUINO_NANO33BLE) | ||
| APDS9960 APDS(Wire1, PIN_INT_APDS); | ||
| #else | ||
| APDS9960 APDS(Wire, -1); | ||
| #endif | ||
| #endif |
Comment on lines
+485
to
+487
| data &= 0b01111111; //MSB reserved | ||
| data |= 0b1; //PowerON | ||
| data |= 0b00010000; //ALS |
There was a problem hiding this comment.
no number create macros and give a meanings to each action
| void APDS9960::enableProximityInterrupt(){ | ||
| uint8_t data; | ||
| getENABLE(&data); | ||
| data &= 0b01111111; //MSB reserved |
There was a problem hiding this comment.
no number create macros and give a meanings to each action
Comment on lines
+456
to
+458
| data &= 0b01111111; //MSB reserved | ||
| data |= 0b1; //PowerON | ||
| data &= 0b01011111; //Int prox disable |
There was a problem hiding this comment.
no number create macros and give a meanings to each action
| @@ -150,4 +168,4 @@ class APDS9960 { | |||
|
|
|||
| extern APDS9960 APDS; | |||
|
|
|||
| #endif // ARDUINO_APDS9960 | |||
| #endif // ARDUINO_APDS9960 | |||
per1234
added
status: changes requested
per1234
dismissed
their stale review
All the changes I requested have been made. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the minimun configuration to enable the interrupt pin